London | 26-SDC-March | Zobeir Rigi | Sprint 1 | Analyse and Refactor Functions - #204
Open
Zobeir-Rigi wants to merge 5 commits into
Open
London | 26-SDC-March | Zobeir Rigi | Sprint 1 | Analyse and Refactor Functions#204Zobeir-Rigi wants to merge 5 commits into
Zobeir-Rigi wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Jul 9, 2026
| export const findCommonItems = (firstArray, secondArray) => { | ||
| const secondSet = new Set(secondArray); | ||
|
|
||
| return [...new Set(firstArray.filter((item) => secondSet.has(item)))]; |
There was a problem hiding this comment.
Could also take advantage of built-in Set operations such as union and intersect for better performance and simpler code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysed and refactored the functions to improve efficiency, added Big-O complexity explanations, and verified that all tests pass.